Remove fzf interactive selection for ros2 service call

[tonynajjar]

Description

After upgrading to Lyrical, I found out that the feature introduced here is not working as expected for ros2service.

When running ros2 service call <service-name>, fzf pulls out a list of service names although we already specified it:

Also plain ros2 service call without a service name does not trigger the fzf list of service names:

ubuntu@dexory:/opt/auto_ws$ ros2 service call
usage: ros2 service call [-h] [-r N] [--timeout N] [--qos-profile {unknown,default,system_default,sensor_data,services_default,parameters,parameter_events,action_status_default,best_available,rosout_default}] [--qos-depth N]
                         [--qos-history {system_default,keep_last,keep_all,unknown}] [--qos-reliability {system_default,reliable,best_effort,unknown,best_available}]
                         [--qos-durability {system_default,transient_local,volatile,unknown,best_available}] [--qos-liveliness {system_default,automatic,manual_by_topic,unknown,best_available}]
                         [--qos-liveliness-lease-duration-seconds QOS_LIVELINESS_LEASE_DURATION_SECONDS]
                         service_name service_type [--stdin | values]
ros2 service call: error: the following arguments are required: service_name, service_type

Aside for the bug, I currently can't see a nice UX for ros2 service call with fzf because currently the command is executed directly after the fzf selection but for ros2 service call more often than not, the user wants to specify the values in the request which is currently not possible. This ties with #1184

For this reason I propose we remove this functionality that does not work until we can find a clean fix and UX

Fixes # (issue)

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

[tonynajjar]

cc @fujitatomoya

[fujitatomoya]

lgtm. (as explained, this is not useful.)

[fujitatomoya]

Pulls: #1244
Gist: https://gist.githubusercontent.com/fujitatomoya/740bd6e280d763a47cc728f5fe4ecfbe/raw/f756e2354a11b91640cb055225f028f5eae52c7d/ros2.repos
BUILD args: --packages-above-and-dependencies ros2service
TEST args: --packages-above ros2service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19591

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mjcarroll]

Is this also broken in rolling? Should we fix it there as well?

[fujitatomoya]

@tonynajjar i think we need to backport this to lyrical, right? this is already there but never really worked. so even if this is kind of behavior change, i think it just gets better for users.

[fujitatomoya]

@Mergifyio backport lyrical

[mergify]

backport lyrical

✅ Backports have been created

Details

• #1246 Remove fzf interactive selection for ros2 service call (backport #1244) has been created for branch lyrical

[tonynajjar]

Yes to be backported to lyrical too please 👍