Skip to content

[master]{common} python3-rospkg: version bump 1.3.0 -> 1.6.1 + ptest - #1796

Open
vermaete wants to merge 1 commit into
ros:masterfrom
vermaete:vermaete/python3-rospkg
Open

[master]{common} python3-rospkg: version bump 1.3.0 -> 1.6.1 + ptest#1796
vermaete wants to merge 1 commit into
ros:masterfrom
vermaete:vermaete/python3-rospkg

Conversation

@vermaete

@vermaete vermaete commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • removed not longer needed .inc file

  • added ptest

  • note the patch on os_detect.py.

    The 'os' 'openembedded' is now discovered by the lsb info.
    But can still be overrulled by the ROS_OS_OVERRIDE variable.

    e.g:

    root@qemux86-64:/usr/lib/python3.14/site-packages# python3 -m rospkg.os_detect
    OS Name:     openembedded
    OS Version:  nodistro.0
    OS Codename: 
    
    root@qemux86-64:/usr/lib/python3.14/site-packages# export ROS_OS_OVERRIDE=ubuntu:18.04:bionic
    
    root@qemux86-64:/usr/lib/python3.14/site-packages# python3 -m rospkg.os_detect
    OS Name:     ubuntu
    OS Version:  18.04
    OS Codename: bionic
    

This patch should be upstreamed soon.

@mergify

mergify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

* removed not longer needed .inc file
* added ptest

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
@robwoolley

Copy link
Copy Markdown
Collaborator

Thanks @vermaete

Is this something we can push upstream to python3-rospkg first and then backport?

I see that there are some comments about distro.id VS disto.name. This is useful. At the next meeting let's chat about what OpenEmbedded does for LSB to make sure that we get the mapping right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants