Detecting OpenEmbedded in rospkg

[vermaete]

Hi,

When working on the ptests for meta-ros I found that the discovery of the os, version and codename in rospkg is not fully implemented.

First the environment variable has to be set:

export ROS_OS_OVERRIDE="openembedded"

A detection on the content of the rootfs could be better.

And version and codename are empty"

root@qemux86-64:/usr/lib/python3.14# python3 -m rospkg.os_detectg
OS Name:     openembedded
OS Version:
OS Codename:

https://github.com/ros-infrastructure/rospkg/blame/master/src/rospkg/os_detect.py#L227

[vermaete]

E.g of missing test with

export ROS_OS_OVERRIDE="openembedded"
ptest-runner python3-rospkg

def test_OsDetect_single():
        # test each method twice with new instance b/c of caching
        from rospkg.os_detect import OsDetect
        detect = OsDetect([('TrueOs', TrueOs())])
>       assert "TrueOs" == detect.get_name()

test/test_rospkg_os_detect.py:544:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../../python3.14/site-packages/_pytest/assertion/rewrite.py:507: in _call_reprcompare
    custom = util._reprcompare(ops[i], each_obj[i], each_obj[i + 1])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../python3.14/site-packages/_pytest/assertion/__init__.py:167: in callbinrepr
    hook_result = ihook.pytest_assertrepr_compare(
../../python3.14/site-packages/pluggy/_hooks.py:512: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../python3.14/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../python3.14/site-packages/_pytest/assertion/__init__.py:208: in pytest_assertrepr_compare
    return util.assertrepr_compare(config=config, op=op, left=left, right=right)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../python3.14/site-packages/_pytest/assertion/util.py:206: in assertrepr_compare
    highlighter = config.get_terminal_writer()._highlight
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <_pytest.config.Config object at 0x7fe187d0c830>

    def get_terminal_writer(self) -> TerminalWriter:
        terminalreporter: TerminalReporter | None = self.pluginmanager.get_plugin(
            "terminalreporter"
        )
>       assert terminalreporter is not None
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError

../../python3.14/site-packages/_pytest/config/__init__.py:1185: AssertionError
FAIL: test/test_rospkg_os_detect.py:test_OsDetect_single
PASS: test/test_rospkg_os_detect.py:test_OsDetect_register_default_add_detector

def test_OsDetect_nomatch():
        from rospkg.os_detect import OsDetect, OsNotDetected
        detect = OsDetect([('Dummy', FalseOs())])
        assert isinstance(detect.get_detector('Dummy'), FalseOs)
        try:
            detect.get_name()
>           assert False
E           assert False

test/test_rospkg_os_detect.py:590: AssertionError

[vermaete]

more info: #1796 (comment)