Repository navigation
Conversation
Test Results 24 files 24 suites 4d 0h 46m 7s ⏱️ For more details on these failures, see this check. Results for commit f3bf7c7. ♻️ This comment has been updated with latest results. |
1 of 2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
The include directories of external dependencies used by a library are stored in the
includePaths[]of its dictionary, and they are added to the interpreter when the library is loaded. When ROOT and its dependencies are built in one place and then relocated, these paths no longer exist but still show up ingSystem->GetIncludePath(). For example, in the LCG nightlies, ROOT and its dependencies are built under/build/jenkins/...and then deployed to CVMFS:This adds
ROOT_DICTIONARY_EXCLUDE_PATHS, a list of path prefixes that are passed to rootcling as-excludePath, so that include paths under them are not stored in the dictionaries (let me know if there is a better way of doing this). They are still used for parsing when generating the dictionaries. This is only useful for builds that are relocated, where the dependencies are found at runtime through the environment of the final installation (e.g.ROOT_INCLUDE_PATH). Nothing changes when the variable is not set. For the case above, it would be-DROOT_DICTIONARY_EXCLUDE_PATHS=/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3.Together with #23704, which does the same for the ROOT build directory, no build paths are left in
gSystem->GetIncludePath().Checklist: