Repository navigation
[cmake] Don't store build directory include paths in dictionaries - #23704
Merged
Merged
Conversation
1 of 2 tasks
Test Results 24 files 24 suites 3d 23h 28m 57s ⏱️ For more details on these failures, see this check. Results for commit 98b2ddd. ♻️ This comment has been updated with latest results. |
Member
|
Thanks! To be checked by ROOT if this is also related #14296 |
Contributor
Author
|
This is only a single path, there are more and this is one way how they can be removed: #14296 |
Contributor
Author
|
The path in the description is now gone in dev3 builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Dictionaries of ROOT libraries store the build directory include path (
${CMAKE_BINARY_DIR}/include) in theirincludePaths[], which is added to the interpreter when the library is loaded. In an installed ROOT this path does not exist anymore, but it still shows up ingSystem->GetIncludePath(), for example (for any ROOT built in the LCG stacks):The include directory is already added by TCling at startup with
TROOT::GetIncludeDir(), so storing it in the dictionaries is not needed, also when running from the build directory. The whole build directory used to be excluded before e1751b1, which narrowed the exclusion toginclude,externalsandbuiltins. The non-module branch ofROOT_GENERATE_DICTIONARYstill excludes all of${CMAKE_BINARY_DIR}. The paths are still passed to rootcling for parsing, only the stored list changes.Checklist: