Repository navigation
[ntuple] Fixes to RNTupleMerger with emulated types - #23702
Open
silverweed wants to merge 3 commits into
Open
silverweed wants to merge 3 commits into
silverweed wants to merge 3 commits into
Conversation
This will collect a bunch of new tests for merging of emulated fields
We need to tell CreateField to emulate late model extended fields.
Test Results 23 files 23 suites 3d 19h 54m 50s ⏱️ For more details on these failures, see this check. Results for commit e8ccc45. |
jblomer
approved these changes
Oct 14, 2026
| ROOT::RVectorField::RVectorField(std::string_view fieldName, std::unique_ptr<RFieldBase> itemField, | ||
| std::optional<std::string_view> emulatedFromType) | ||
| : ROOT::RFieldBase(fieldName, emulatedFromType ? *emulatedFromType : "std::vector<" + itemField->GetTypeName() + ">", | ||
| const ROOT::RFieldDescriptor *emulatedFrom) |
Contributor
There was a problem hiding this comment.
Ok for now, we'll come back to this to avoid disguising an untyped record as an emulated record. This is a pre-existing issue, of course.
2 tasks done
Also add a test for merging emulated Vector field
silverweed
force-pushed
the
ntuple_merge_emu
branch
from
October 16, 2026 07:22
e8ccc45 to
1ac51aa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
starts adding some systematic testing for merging RNTuples containing emulated fields. In particular the end goal is to test all types of emulated fields with and without late model extension.
Adding some basic testing of emulated fields + late model extension (aka Union merging) surfaced some bugs since the code path was never exercised before. This was brought to light by #23684.
This PR starts setting the foundation for this new set of tests along with fixes for the problems found so far. It doesn't address yet the issue brought up by the PR linked above, but the idea is to get to the best solution for it incrementally.
Changes or fixes:
MergeEmulatedtest fromntuple_emulatedto newntuple_merge_emulatedtest fileEmulateUnknownTypesflag toCreateFieldcalls in case of late model extensionChecklist: