Skip to content

[io] Add gtest-based cpp11Containers unordered_map test - #23021

Merged
vepadulano merged 1 commit into
root-project:masterfrom
vepadulano:cpp11Containers-unorderedmap-gtest
Sep 1, 2026
Merged

vepadulano merged 1 commit into
root-project:masterfrom
vepadulano:cpp11Containers-unorderedmap-gtest

Conversation

@vepadulano

Copy link
Copy Markdown
Member

This is a re-write of the cpp11Containers-unorderedMap test as a compiled C++ program based on gtest. Given the recent intermittent CI failures, the new test could help identify in a more fine-grained way the root cause. It is an addition rather than a substitution because there is no guarantee that the cause of the CI failure is in the test itself.

@vepadulano vepadulano self-assigned this Aug 5, 2026
@vepadulano
vepadulano force-pushed the cpp11Containers-unorderedmap-gtest branch 6 times, most recently from 8060e9c to ebcd9f7 Compare August 5, 2026 13:37
@github-actions

github-actions Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 16h 12m 32s ⏱️
 3 862 tests  3 859 ✅ 0 💤 3 ❌
78 699 runs  78 695 ✅ 1 💤 3 ❌

For more details on these failures, see this check.

Results for commit 7bab764.

♻️ This comment has been updated with latest results.

@vepadulano
vepadulano force-pushed the cpp11Containers-unorderedmap-gtest branch 4 times, most recently from 4a52dd2 to f4badb0 Compare August 6, 2026 13:29
@vepadulano vepadulano closed this Aug 7, 2026
@vepadulano vepadulano reopened this Aug 7, 2026
@vepadulano
vepadulano requested a review from pcanal August 7, 2026 09:42
@vepadulano
vepadulano marked this pull request as ready for review August 7, 2026 09:42
@vepadulano

Copy link
Copy Markdown
Member Author

I've seen the unorderedMap macro-based test fail already a couple of times in this PR and at the same time the equivalent gtest-based test introduced by these changes was not failing. I propose we merge this extra test and see in the long-term if it fails over multiple CI runs, and if not we could just remove the macro-based one.

@pcanal

pcanal commented Aug 25, 2026

Copy link
Copy Markdown
Member

Closing and re-opening to see if the new test is sturdier than the old one.

@pcanal pcanal closed this Aug 25, 2026
@pcanal pcanal reopened this Aug 25, 2026
@pcanal pcanal closed this Aug 25, 2026
@pcanal pcanal reopened this Aug 25, 2026
@pcanal

pcanal commented Aug 26, 2026

Copy link
Copy Markdown
Member

Closing and re-opening to see if the new test is sturdier than the old one.

@pcanal pcanal closed this Aug 26, 2026
@pcanal pcanal reopened this Aug 26, 2026
This is a re-write of the cpp11Containers-unorderedMap test as a compiled C++
program based on gtest. Given the recent intermittent CI failures, the new test
could help identify in a more fine-grained way the root cause. It is an addition
rather than a substitution because there is no guarantee that the cause of the
CI failure is in the test itself.
@vepadulano
vepadulano force-pushed the cpp11Containers-unorderedmap-gtest branch from f4badb0 to 7bab764 Compare August 31, 2026 07:48
@pcanal

pcanal commented Aug 31, 2026

Copy link
Copy Markdown
Member

and if not we could just remove the macro-based one.

Until proven otherwise we have to assume that the failure are indicative of a real problem that might affect users. Consequently we can not simply remove the test. However we could/should disable by default and re-open a PR that turns it back and where we can continue investigating the underlying cause.

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vepadulano
vepadulano merged commit d7a9dc0 into root-project:master Sep 1, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants