Repository navigation
[roottest] Use heap-allocated TFile and TTree in test - #23147
Closed
vepadulano wants to merge 1 commit into
Closed
vepadulano wants to merge 1 commit into
vepadulano wants to merge 1 commit into
Conversation
Multiple times in the past stack-allocated TFile/TTree have produced random test failures and/or timeouts. Adopt the same strategy done elsewhere, i.e. rely on heap-allocated TFile and TTree.
Test Results 23 files 23 suites 3d 15h 18m 1s ⏱️ For more details on these failures, see this check. Results for commit 1556c85. |
pcanal
reviewed
Aug 25, 2026
| t.Branch("vecHistoCont", &vecHistoCont,16000,0); | ||
| t.Branch("contHistoVec_split", &contHistoVec,16000,99); | ||
| t.Branch("contHistoVec", &contHistoVec,16000,0); | ||
| auto f = std::make_unique<TFile>(binFilename.c_str(), "UPDATE"); |
Member
There was a problem hiding this comment.
Unfortunately the test still failed despite this change :(
pcanal
approved these changes
Aug 25, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
I have no particular objection to this update (beside that it does not seems to help the test).
Member
Author
|
Since this test is not failing only because of eventual problems with stack-allocated TFile/TTree, I will go ahead and close the PR. We can continue the investigation/discussion at #23021 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple times in the past stack-allocated TFile/TTree have produced random test failures and/or timeouts. Adopt the same strategy done elsewhere, i.e. rely on heap-allocated TFile and TTree.
This is related to #23021 . While I still believe the googletest-based test would be better to have in the longer term, with this PR we can gauge whether the intermittent CI failures are actually do to the stack-allocated TFile/TTree as it happened in the past.