Skip to content

Stop micromanaging the CLI flags #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderik merged 1 commit into from
Apr 7, 2026
Merged

Stop micromanaging the CLI flags #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/__flock_tab_setup.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
function __flock_tab_setup --description "Open a new workspace tab scoped to a directory — auto-detects zellij/cmux/bare"
set -l tab_name ""
set -l workdir (pwd)
set -l cli claude --dangerously-skip-permissions
set -l cli claude

Comment on lines +4 to 5

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default CLI is now just claude (no --dangerously-skip-permissions), the later inline comment/example in this function that still includes that flag is now out of date. Please update the example so it reflects the new launch command.

Copilot uses AI. Check for mistakes.
argparse 'x' 'name=' 'dir=' 'prompt=' -- $argv 2>/dev/null

if set -q _flag_x
set cli codex --full-auto
set cli codex
end
Comment on lines +4 to 10

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters the command string injected into the Zellij/cmux pane (removing default flags). Consider adding a small fishtape test that stubs zellij/cmux and asserts the injected write-chars/send command is exactly claude (or codex with -x), to prevent accidental reintroduction of hard-coded flags.

Copilot uses AI. Check for mistakes.
set -q _flag_name; and set tab_name $_flag_name
set -q _flag_dir; and set workdir $_flag_dir
Expand Down
Loading