Skip to content

Stop micromanaging the CLI flags#21

Merged
roderik merged 1 commit into
mainfrom
roderik/fix-startup-flow
Apr 7, 2026
Merged

Stop micromanaging the CLI flags#21
roderik merged 1 commit into
mainfrom
roderik/fix-startup-flow

Conversation

@roderik

@roderik roderik commented Apr 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removed --dangerously-skip-permissions from the claude default and --full-auto from the codex override
  • The shell abbreviations already dress these commands properly — no need for the script to backseat-drive

Test plan

  • flock tab-setup launches claude (abbreviation adds permissions flag)
  • flock tab-setup -x launches codex (abbreviation adds full-auto)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 7, 2026 06:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes hard-coded “micromanaging” flags from __flock_tab_setup so the launched assistant command is just claude by default (or codex with -x), relying on the user environment to supply any desired defaults.

Changes:

  • Removed --dangerously-skip-permissions from the default claude launch command.
  • Removed --full-auto from the codex override when -x is used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to 10
set -l cli claude

argparse 'x' 'name=' 'dir=' 'prompt=' -- $argv 2>/dev/null

if set -q _flag_x
set cli codex --full-auto
set cli codex
end

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters the command string injected into the Zellij/cmux pane (removing default flags). Consider adding a small fishtape test that stubs zellij/cmux and asserts the injected write-chars/send command is exactly claude (or codex with -x), to prevent accidental reintroduction of hard-coded flags.

Copilot uses AI. Check for mistakes.
Comment on lines +4 to 5
set -l cli claude

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default CLI is now just claude (no --dangerously-skip-permissions), the later inline comment/example in this function that still includes that flag is now out of date. Please update the example so it reflects the new launch command.

Copilot uses AI. Check for mistakes.
@roderik roderik merged commit 061d23f into main Apr 7, 2026
7 checks passed
@roderik roderik deleted the roderik/fix-startup-flow branch April 7, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants