Stop micromanaging the CLI flags#21
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes hard-coded “micromanaging” flags from __flock_tab_setup so the launched assistant command is just claude by default (or codex with -x), relying on the user environment to supply any desired defaults.
Changes:
- Removed
--dangerously-skip-permissionsfrom the defaultclaudelaunch command. - Removed
--full-autofrom thecodexoverride when-xis used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| set -l cli claude | ||
|
|
||
| argparse 'x' 'name=' 'dir=' 'prompt=' -- $argv 2>/dev/null | ||
|
|
||
| if set -q _flag_x | ||
| set cli codex --full-auto | ||
| set cli codex | ||
| end |
There was a problem hiding this comment.
This change alters the command string injected into the Zellij/cmux pane (removing default flags). Consider adding a small fishtape test that stubs zellij/cmux and asserts the injected write-chars/send command is exactly claude (or codex with -x), to prevent accidental reintroduction of hard-coded flags.
| set -l cli claude | ||
|
|
There was a problem hiding this comment.
Since the default CLI is now just claude (no --dangerously-skip-permissions), the later inline comment/example in this function that still includes that flag is now out of date. Please update the example so it reflects the new launch command.
Summary
--dangerously-skip-permissionsfrom theclaudedefault and--full-autofrom thecodexoverrideTest plan
flock tab-setuplaunchesclaude(abbreviation adds permissions flag)flock tab-setup -xlaunchescodex(abbreviation adds full-auto)🤖 Generated with Claude Code