Repository navigation
feat: trackpad D-pad in every mode, D-pad feedback, per-type QAM + Select - #20
Merged
Merged
Conversation
…lect Trackpad D-pad (on touch or on click, diagonals included) was Switch Pro only; every emulated mode now offers it: Xbox 360 and OG, Switch (Pro and Hori), DS4, DS5, HIDGYRO and PS3. A pad on D-pad on click spends its click on the D-pad, so the click's own mapping does not fire with it, and the panel greys that pad's Click setting out. The Switch-only D-pad click feedback becomes a per-type setting, D-pad feedback (grid setting 7, on by default; the Switch's starts from the old byte). It pulses the pad each time its direction changes, so sliding from down to down-right is felt without lifting a finger, and on each D-pad click while Trackpad haptics is off (every click already pulses then). Quick Access + Select, also Switch-only (screenshot), is now a target per controller type, set in a Quick Access group of the Button map card. It is always on and none by default, so the enable switch is gone; a file from before keeps the Switch's target only if that switch was on. Any button works, including the Guide, Home or PS button. Panel layout: Trackpads (Touch and Click per pad) and a new Trackpad feedback card are separate; Trackpad feedback, Adaptive triggers and Lights form one column, Rumble and Haptics another; Switch Pro mode only follows the Button map card. The status blob grows to p[251]. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three things that were Switch-only now work in every emulated mode, plus a panel reshuffle.
Protocol
Both settings are appended to the existing per-type layout. Older panels keep working: field 230 (D-pad click feedback) and 239 (QAM + Select target) still set the Switch's entry.
120 + 4·7 + type(setting 7)p[244..247]0off,1on; default 1152 + typep[248..251]0–20; default 0Details in
docs/PROTOCOL.md,docs/CONTROLLER_FEATURES.mdand the README.Tests
tests/switch_pro_shortcuts: D-pad directions, the click-pulse guard, a pulse per direction change in touch and click modes, the click taking the D-pad, and the always-on chord with its migration.tests/type_haptics,tests/final_webusb,tests/button_map: the new settings, blob bytes, fields and builders.tests/button_profiles/panel.cjs: Click greyed out on D-pad options, the per-type QAM + Select rows, and the new cards.make check, all host tests and the three UI tests pass; the firmware builds.Not yet checked on hardware at this commit: the direction-change pulses and QAM + Select on a real controller.
🤖 Generated with Claude Code