Repository navigation
Acquire API coordinate matches through PackageHouse - #9945
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 1 is complete for PR #9945.
Progress: 1 pushed candidate, 1 usable review, 0 accepted findings. Resolution: no code changes; the review found no qualifying correctness, security, reliability, or contract defects. The existing transfer-volume receipt remains explanatory evidence, not a runtime-performance claim. — Authored with GitHub Copilot CLI |
|
Exact base/head NativeAOT evidence is now available from approved host
Protocol: SDK The candidate is not performance-neutral for this cold product-cache scenario. It transfers 62.059% fewer package bytes but materially increases latency and peak RSS. Per the performance gate, this stops merge readiness pending operator direction; I am not seeking a second host merely to reconfirm the miss. — Authored with GitHub Copilot CLI |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 2 is complete for PR #9945.
Progress: 2 pushed candidates, 2 usable reviews, 0 accepted findings. Resolution: round 1 remained clean; its NativeAOT obligation is resolved. Candidate 2 removes redundant ranged-entry persistence and narrows demand to the compile surface actually consumed by coordinate correspondence. Exact NativeAOT evidence is +3.6% median elapsed, -4.1% median max RSS, and -81.251% transferred bytes versus base, with all semantic gates and current-head CI green. — Authored with GitHub Copilot CLI |
dotnet-inspect builds robust, capable inspection features that provide foundational capabilities or compelling experiences and are conventionally sound, delightfully new or unique, or both.
Closes #9941.
Design basis
docs/design/package-house.mdowns exact package source authority, payload acquisition, target realization, and producer correspondence.Standalone API coordinate matching now declares one exact compile realization per distinct endpoint, consumes the House-issued compile-selection receipt, and leaves cache, ranged-entry, and complete-fallback policy with the host. Destination realization remains constrained to the typed producer identity selected for the source.
Changes
Evidence
11.0.100-rc.1.26425.128ApiCoordinateMatchInspectionTests: 13/13 passednpx markdownlint-cli docs/design/package-house.mdgit diff --checkThe deterministic loopback NuGet V3 receipt preserved byte-identical CLI output for:
The previous path downloaded two complete archives totaling 23,113,820 bytes. The final House path uses 11
206reads totaling 4,333,573 bytes: 18,780,247 fewer transferred bytes, an 81.251% reduction, for the same semantic result.NativeAOT performance
Exact base
d93cb58f8b5c44ecc831158db64cee502a7e63e6and exact head8920eea9c7b55226be36aa6da9bf2334abe567efwere published with SDK11.0.100-rc.1.26425.128forlinux-x64and measured on approved hostdotnet-inspect-perfthroughperf-guard.The deterministic loopback feed served the same Avalonia scenario above. After one unmeasured prime per binary, ten measured invocations per revision used unique isolated product state and alternating base/head order.
The first candidate eagerly ranged both reference and separate implementation populations and retained a duplicate operation-local entry-cache copy. It measured +30.8% median elapsed and +21.8% median max RSS. Coordinate correspondence consumes API declarations, assembly identities, references, and type forwarders from the selected compile surface; it does not inspect implementation bodies. The repaired candidate requests
Surface, and packages without a separate reference surface already uselib/as their surface. Removing redundant entry persistence and the unconsumed implementation population recovers near-neutral latency, lowers peak RSS, and increases the byte reduction from 62.059% to 81.251%.Two complete
ApiCoordinateMatchCommandTestsverbosity/envelope cases and sevenConfiguredPayloadAcquisitionTestslocal-feed assertions fail identically on the exact base; focused gates covering this change pass.Scope
This does not migrate Browser coordinate controls, portable Workspace coordinate replacement, exact-Library selection, or the deprecated
PackageAssemblyQueryadapter tracked for retirement by #6797 after #6795.