Skip to content

functional-tests: replace /retest comment with ok_to_test label #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owtaylor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

functional-tests: replace /retest comment with ok_to_test label #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions .github/workflows/functional-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,37 @@ on:
branches:
- main
pull_request_target:
types: [opened, synchronize, labeled]
branches:
- main
issue_comment:
types: [created]
workflow_dispatch:

permissions:
contents: read
pull-requests: read
pull-requests: write

jobs:
check-authorization:
name: Check Authorization
runs-on: ubuntu-latest
if: >-
github.event_name != 'issue_comment' ||
(github.event.issue.pull_request &&
(startsWith(github.event.comment.body, '/test-functional') ||
startsWith(github.event.comment.body, '/retest')))
github.event.action != 'labeled' ||
github.event.label.name == 'ok_to_test'
outputs:
authorized: ${{ steps.check.outputs.authorized }}
steps:
- name: Remove ok_to_test label
if: github.event.action == 'labeled'
uses: actions/github-script@v9
with:
script: |
await github.rest.issues.removeLabel({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.payload.pull_request.number,
name: 'ok_to_test',
});

- name: Check if user is authorized
id: check
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
Expand All @@ -39,18 +48,6 @@ jobs:
if (eventName === 'push' || eventName === 'workflow_dispatch') {
authorized = true;
} else {
if (eventName === 'issue_comment') {
if (!context.payload.issue.pull_request) {
core.setFailed('issue_comment event on a non-PR issue should have been filtered by job condition');
return;
}
const body = context.payload.comment.body;
if (!/^\/(test-functional|retest)/.test(body)) {
core.setFailed('issue_comment without trigger command should have been filtered by job condition');
return;
}
}

try {
const { data: permission } = await github.rest.repos.getCollaboratorPermissionLevel({
owner: context.repo.owner,
Expand Down Expand Up @@ -93,8 +90,6 @@ jobs:
let prNumber;
if (context.eventName === 'pull_request_target') {
prNumber = context.payload.pull_request.number;
} else if (context.eventName === 'issue_comment') {
prNumber = context.issue.number;
}

if (prNumber) {
Expand Down