functional-tests: replace /retest comment with ok_to_test label#522
Open
owtaylor wants to merge 1 commit into
Open
functional-tests: replace /retest comment with ok_to_test label#522owtaylor wants to merge 1 commit into
owtaylor wants to merge 1 commit into
Conversation
The issue_comment trigger produces check runs associated with main's HEAD, not the PR's head commit, so a successful retest never replaced the original failed check in the PR status summary. Switching to a pull_request_target labeled trigger keeps the same (workflow, event, SHA) identity, so the new result properly supersedes the old one. The ok_to_test label is removed immediately — before the authorization check — so it can always be re-added regardless of whether the actor was authorized. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue_comment trigger produces check runs associated with main's HEAD, not the PR's head commit, so a successful retest never replaced the original failed check in the PR status summary. Switching to a pull_request_target labeled trigger keeps the same (workflow, event, SHA) identity, so the new result properly supersedes the old one.
The ok_to_test label is removed immediately — before the authorization check — so it can always be re-added regardless of whether the actor was authorized.
This is an implementation of the idea from: #389 (comment)
I used a generic ok_to_test label here, because if we had multiple tests that we wanted to gate this way (needs security look-over from a maintainer) we'd only want to do that once per commit.
Assisted-by: Claude Opus 4.6 noreply@anthropic.com
Closes: #389