Skip to content

ExternsDiff: Consider all types recursively in instance head as dependencies #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyla merged 1 commit into from
Jun 23, 2025
Merged

ExternsDiff: Consider all types recursively in instance head as dependencies #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Language/PureScript/Make/ExternsDiff.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ externsDeclarationToRef moduleName = \case
--
P.EDInstance cn n args kinds types constraints _ _ _ _ ->
Just
( TypeInstanceRef n (qualified cn) (mapMaybe myType types)
( TypeInstanceRef n (qualified cn) (foldMap (P.everythingOnTypes (<>) (maybeToList . myType)) types)
, maybe mempty constraintsDeps constraints <> instanceArgsDeps args <> foldMap typeDeps kinds
)
where
Expand Down
Loading