ExternsDiff: Consider all types recursively in instance head as dependencies - #10
Merged
Merged
Conversation
jborkowski
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes recompilation bug reproduced by https://github.com/zyla/purs-recompilation-repro-2.
The bug happens in converting an EDInstance to a Ref.
TypeInstanceRefcontains a list of local types mentioned in the instance head. However, the conversion only detected types mentioned directly in the instance head without arguments.So in the reproduction example, we get the following entry in
depsDiffs:ProperName {runProperName = "Bar"}),Updated),(TypeInstanceRef (Ident "fooBar") (ModuleName "TC",ProperName {runProperName = "Foo"}) []When we should get:
ProperName {runProperName = "Bar"}),Updated),(TypeInstanceRef (Ident "fooBar") (ModuleName "TC",ProperName {runProperName = "Foo"}) [ProperName {runProperName = "Bar"}]The fix is to recursively traverse the instance head, searching for local types.