fix(deps): remove unused dependencies (xmldict, distlib) - #228
Merged
Conversation
xmldict is declared in pyproject.toml but never imported or used anywhere in the codebase (src/ and tests/ have zero references). Its legacy setup.py format causes ImportError on Python 3.13. All XML parsing in the project uses the stdlib xml.etree.ElementTree instead. Removing this dependency resolves the installation failure on Python 3.13 without any code changes. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
distlib is declared in pyproject.toml but never imported or used anywhere in the codebase (src/ and tests/ have zero references). Originally added in commit b157d8b for PyPI sdist support but never implemented. Removing this unused dependency reduces installation overhead and eliminates an unnecessary transitive dependency. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
The CI workflow was running all tests including integration tests by using -m "" (empty marker filter). Integration tests require external resources (Maven artifacts, Git repos) and should be skipped by default in CI. Use the standard marker filter -m "not slow and not integration" to match pyproject.toml configuration and only run unit tests in the build pipeline. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
jimisola
force-pushed
the
fix/remove-unused-dependencies
branch
from
February 25, 2026 11:50
5efab13 to
216cbfa
Compare
jimisola
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two unused dependencies that were declared in
pyproject.tomlbut never imported or used in the codebase:xml.etree.ElementTreeChanges
xmldict==0.4.1from dependencies (commit dab961e)distlib==0.4.0from dependencies (commit 9da1b60)Verification
Both packages have zero references in
src/andtests/:All XML parsing uses stdlib
xml.etree.ElementTree(testdata_model_generator.py:6)Test Plan