Skip to content

Commit 61ce32f

Browse files
authored
fix(deps): remove unused dependencies (xmldict, distlib) (#228)
* fix(deps): remove unused xmldict==0.4.1 dependency xmldict is declared in pyproject.toml but never imported or used anywhere in the codebase (src/ and tests/ have zero references). Its legacy setup.py format causes ImportError on Python 3.13. All XML parsing in the project uses the stdlib xml.etree.ElementTree instead. Removing this dependency resolves the installation failure on Python 3.13 without any code changes. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com> * fix(deps): remove unused distlib==0.4.0 dependency distlib is declared in pyproject.toml but never imported or used anywhere in the codebase (src/ and tests/ have zero references). Originally added in commit b157d8b for PyPI sdist support but never implemented. Removing this unused dependency reduces installation overhead and eliminates an unnecessary transitive dependency. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com> * fix(ci): exclude integration tests from pytest in build workflow The CI workflow was running all tests including integration tests by using -m "" (empty marker filter). Integration tests require external resources (Maven artifacts, Git repos) and should be skipped by default in CI. Use the standard marker filter -m "not slow and not integration" to match pyproject.toml configuration and only run unit tests in the build pipeline. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com> --------- Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
1 parent eb56b43 commit 61ce32f

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@ jobs:
2828
python-version: "3.13"
2929
- name: Install dependencies
3030
run: pip install hatch
31-
- name: Run unit and integrations tests
32-
env:
33-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
34-
run: hatch run dev:pytest -m "" --cov=reqstool --cov-report=html -o junit_family=xunit2 --junitxml=build/junit.xml
31+
- name: Run unit tests
32+
run: hatch run dev:pytest -m "not slow and not integration" --cov=reqstool --cov-report=html -o junit_family=xunit2 --junitxml=build/junit.xml
3533
- name: Build project
3634
run: hatch build
3735
- name: Test reqstool-client from build by installing and running

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ requires-python = ">=3.10"
4848

4949
dependencies = [
5050
"colorama==0.4.6",
51-
"distlib==0.4.0",
5251
"Jinja2==3.1.6",
5352
"jsonpickle==4.1.1",
5453
"jsonschema[format-nongpl]==4.26.0",
@@ -59,7 +58,6 @@ dependencies = [
5958
"requests-file==3.0.1",
6059
"ruamel.yaml==0.19.1",
6160
"tabulate==0.9.0",
62-
"xmldict==0.4.1",
6361
"reqstool-python-decorators==0.0.9",
6462
"packaging==26.0",
6563
"requests==2.32.5",

0 commit comments

Comments
 (0)