Skip to content

fix(orchestrator): lowercase and truncate DB creation Job name for compliance [RHDHBUGS-3329] #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rm3l wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

fix(orchestrator): lowercase and truncate DB creation Job name for compliance [RHDHBUGS-3329] #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ sources: []
# Versions are expected to follow Semantic Versioning (https://semver.org/)
# Note that when this chart is published to https://github.com/openshift-helm-charts/charts
# it will follow the RHDH versioning 1.y.z
version: 6.2.0
version: 6.2.1
4 changes: 2 additions & 2 deletions charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

# RHDH Backstage Helm Chart for OpenShift

![Version: 6.2.0](https://img.shields.io/badge/Version-6.2.0-informational?style=flat-square)
![Version: 6.2.1](https://img.shields.io/badge/Version-6.2.1-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub, which is a Red Hat supported version of Backstage.
Expand Down Expand Up @@ -29,7 +29,7 @@ For the **Generally Available** version of this chart, see:
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add redhat-developer https://redhat-developer.github.io/rhdh-chart

helm install my-backstage redhat-developer/backstage --version 6.2.0
helm install my-backstage redhat-developer/backstage --version 6.2.1
```

## Introduction
Expand Down
10 changes: 10 additions & 0 deletions charts/backstage/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,16 @@ images are configured.
{{- join "," $imgs -}}
{{- end -}}

{{/*
Returns the orchestrator DB creation Job name, lowercased and truncated to 63 chars.
The version suffix is preserved in full; only the prefix is truncated.
*/}}
{{- define "rhdh.orchestrator.dbJobName" -}}
{{- $versionSuffix := printf "-%s" (.Chart.Version | replace "." "-") -}}
{{- $prefix := printf "%s-create-sf-db" .Release.Name | trunc (int (sub 63 (len $versionSuffix))) | trimSuffix "-" -}}
{{- printf "%s%s" $prefix $versionSuffix | lower -}}
{{- end -}}

{{/*
DEPRECATED: The following templates are deprecated. Please use the corresponding "rhdh.*" templates instead.
*/}}
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/templates/sonataflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ spec:
apiVersion: batch/v1
kind: Job
metadata:
name: {{ .Release.Name }}-create-sf-db-{{ .Chart.Version | replace "." "-" }}
name: {{ include "rhdh.orchestrator.dbJobName" . }}
namespace: {{ .Release.Namespace }}
spec:
{{- with .Values.orchestrator.sonataflowPlatform.dbCreationJobTTLSecondsAfterFinished }}
Expand Down
Loading