fix(orchestrator): lowercase and truncate DB creation Job name for compliance [RHDHBUGS-3329]#466
Open
rm3l wants to merge 1 commit into
Conversation
…C 1123 compliance The versioned Job name introduced in e767157 did not sanitize the chart version, so versions containing uppercase characters (e.g. 1.10-147-CI) produced an invalid Kubernetes resource name. Add a helper that lowercases the full name and truncates the prefix to keep the total within 63 characters while preserving the version suffix. Ref: RHDHBUGS-3450 Assisted-by: Claude
|
rm3l
changed the title
rm3l
changed the title
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Jul 9, 2026
Replicate the fix from PR redhat-developer#466 (backstage chart) into the rhdh chart. Chart versions with uppercase characters (e.g. CI builds) produced Job names violating RFC 1123 subdomain rules. Add rhdh.orchestrator.dbJobName helper that lowercases the name and truncates to 63 chars while preserving the version suffix. Ref: redhat-developer#466 Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The versioned Job name introduced in e767157 (PR #427) embedded
.Chart.Versioninto the orchestrator DB creation Job name without sanitizing it. Chart versions containing uppercase characters (e.g.,1.10-147-CI) produce a Job name likeredhat-developer-hub-create-sf-db-1-10-147-CI, which violates Kubernetes RFC 1123 subdomain naming rules.Cherry-picked from release-1.10 PR #465.
Which issue(s) does this PR fix or relate to
How to test changes / Special notes to the reviewer
A CI chart version should work properly once this is merged. Also, installing a very long release name should truncate to 63 chars with version suffix preserved.
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Runpre-commit run --all-filesto run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.pre-commithook.ct lintcommand.