Skip to content

[perf] Skip reflection in RemoveDuplicatedReturnSelfDocblockRector without a docblock #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Oct 11, 2026
Merged

[perf] Skip reflection in RemoveDuplicatedReturnSelfDocblockRector without a docblock #8631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3477d
[perf] Skip reflection in RemoveDuplicatedReturnSelfDocblockRector wi…
TomasVotruba Oct 11, 2026
ba43a3b
[ci-review] Rector Rectify
actions-user Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rules/DeadCode/Rector/ClassMethod/RemoveDuplicatedReturnSelfDocblockRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Rector\DeadCode\Rector\ClassMethod;

use PhpParser\Comment\Doc;
use PhpParser\Node;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
Expand Down Expand Up @@ -92,6 +93,11 @@ public function refactor(Node $node): ?Node
return null;
}

// a duplicated @return tag can only live in a docblock; skip before resolving reflection
if (!$node->getDocComment() instanceof Doc) {
return null;
}

$classReflection = $this->reflectionResolver->resolveClassReflection($node);
if (! $classReflection instanceof ClassReflection) {
return null;
Expand Down
Loading