Repository navigation
[perf] Skip reflection in RemoveDuplicatedReturnSelfDocblockRector without a docblock - #8631
Merged
Merged
Conversation
…thout a docblock The rule resolved a ClassReflection and built a PhpDocInfo for every self/static returning method. A duplicated @return tag can only live in a docblock, so add a getDocComment() guard before the reflection resolution. A method without a docblock is a no-op anyway, so this skips the reflection work for it. Behaviour unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the RenameClassRector phpdoc-guard optimization.
RemoveDuplicatedReturnSelfDocblockRectorresolved aClassReflectionand built aPhpDocInfofor everyself/staticreturning method. A duplicated@returntag can only live in a docblock, so a method without one is always a no-op.Add a
getDocComment() !== nullguard right after the self/static check and before the reflection resolution, so doc-less methods skip both the reflection and the phpdoc work. Behaviour identical.Tests green, ECS + PHPStan level 8 clean.