Skip to content

[DeadCode] Speed up RemoveUnusedVariableAssignRector by skipping deep body walk #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 10, 2026
Merged

[DeadCode] Speed up RemoveUnusedVariableAssignRector by skipping deep body walk #8605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,15 @@ public function refactor(Node $node): null|ClassMethod|Function_
return null;
}

// we cannot be sure here
if ($this->shouldSkip($stmts)) {
$assignedVariableNamesByStmtPosition = $this->resolvedAssignedVariablesByStmtPosition($stmts);
if ($assignedVariableNamesByStmtPosition === []) {
return null;
}

$assignedVariableNamesByStmtPosition = $this->resolvedAssignedVariablesByStmtPosition($stmts);
// we cannot be sure here, deep walk only when there is a candidate to remove
if ($this->shouldSkip($stmts)) {
return null;
}

$hasChanged = false;

Expand Down
Loading