Repository navigation
[DeadCode] Speed up RemoveUnusedVariableAssignRector by skipping deep body walk - #8605
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-perf-remove-unused-assign
branch
from
October 10, 2026 22:36
35bdc4c to
886932e
Compare
…edVariableAssignRector
TomasVotruba
force-pushed
the
tv-perf-remove-unused-assign
branch
from
October 10, 2026 22:44
bf55f95 to
f8bda52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf
RemoveUnusedVariableAssignRectorranshouldSkip()first, which does aBetterNodeFinder::findFirst()deep walk over the whole method body (looking forinclude/compact/get_defined_vars) on every method, before knowing if there is anything removable.resolvedAssignedVariablesByStmtPosition()only inspects top-levelExpression(Assign)statements. When it returns nothing, there is no candidate to remove and the deep walk is wasted.Reordered so the cheap candidate collection runs first; the full-body walk only runs when a removable assign actually exists. Behavior unchanged -
shouldSkipstill gates removal whenever candidates are present.