Clear pre-existing clippy -D warnings failures on Windows - #423
Open
RufanMelfor wants to merge 1 commit into
Open
Clear pre-existing clippy -D warnings failures on Windows#423RufanMelfor wants to merge 1 commit into
RufanMelfor wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA. Thank you! |
…nings failures on Windows cargo clippy --all-targets -- -D warnings currently fails on a clean checkout of main, unrelated to any specific feature work: - interop/d3d11.rs: D3d11StagingPool::stage_frame dereferences a raw pointer without being `unsafe fn` (clippy::not_unsafe_ptr_arg_deref). Marked unsafe with a `# Safety` doc; updated the four call sites in frame_processing.rs accordingly. - session/mod.rs, detection_dispatch.rs: gpu_buf_info / cuda_nv12_frames / detect_and_update_director_gpu were cfg'd for linux+windows, but their only callers (the GpuResident zero-copy match arms) are Linux-only - narrowed the cfg gates to match, clearing dead_code. - reco-io/smart_source.rs: WindowsDecodeState::Running carried join_handles/shutdown fields that were never read (matched away with `..` at every destructure site) - the Windows D3D11VA decode threads exit via channel drop, not a join+shutdown flag like the Linux CUDA path (which has a real ordering hazard); removed the dead fields and collapsed a nested if into a let-chain along the way. - reco-autocam/lib.rs: is_10bit is only read by the tensorrt-native path and the Linux ORT-GPU path; gated the binding to match so an ort-only Windows build doesn't warn on it. Verified: cargo fmt --check / clippy -p reco-core -p reco-io -p reco-autocam --all-targets -- -D warnings / test --lib all clean on Windows (the only 2 test failures are the pre-existing CUDA hardware-gap tests, unrelated - no working CUDA runtime on this machine). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
RufanMelfor
force-pushed
the
fix/d3d11-stage-frame-unsafe
branch
from
July 16, 2026 10:35
75e724c to
53ce023
Compare
This was referenced Jul 16, 2026
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo clippy --all-targets -- -D warningscurrently fails on a cleancheckout of
mainon Windows — unrelated to any feature work, just foundincidentally while verifying another branch. Four issues:
interop/d3d11.rs:D3d11StagingPool::stage_framedereferences a rawpointer without being
unsafe fn(clippy::not_unsafe_ptr_arg_deref).Marked
unsafewith a# Safetydoc comment; updated the four callsites in
frame_processing.rsaccordingly.session/mod.rs,detection_dispatch.rs:gpu_buf_info/cuda_nv12_frames/detect_and_update_director_gpuwerecfg'd forlinux+windows, but their only callers (theGpuResidentzero-copymatch arms) are Linux-only — narrowed the cfg gates to match, clearing
dead-code warnings.
reco-io/smart_source.rs:WindowsDecodeState::Runningcarriedjoin_handles/shutdownfields that were never read (matched away with..everywhere) — the Windows D3D11VA decode threads exit via channeldrop, not a join+shutdown flag like the Linux CUDA path (which has a
real ordering hazard the flag actually guards). Removed the dead fields.
reco-autocam/lib.rs:is_10bitis only read by thetensorrt-nativepath and the Linux ORT-GPU path; gated the binding to match so an
ort-only Windows build doesn't warn.
Verified:
fmt/clippy --all-targets -- -D warningsfully clean onWindows against current
origin/main.