reco-gui: flat control language restyle - #433
Open
RufanMelfor wants to merge 1 commit into
Open
Conversation
One consistent flat visual language across the toolbar and panels, replacing std-widgets Button and the earlier ad-hoc SectionHeader. - New FlatButton component (28px, 7px radius, flat fill + hover lighten, blue `primary` variant) replaces all std-widgets Button usages across toolbar, panels, and dialogs. - New TransportButton component for the tight playback-controls cluster (jump/step/play icons); the play/pause button gets an `emphasized` (accent-tinted, wider) variant. - SectionHeader rebuilt: filled yellow square when expanded (visible at a glance across a stack of collapsed sections) plus a ›/⌄ chevron, instead of a plain ▸/▾ text glyph. - Color tokens re-based to cool-biased dark neutrals (a hint of blue toward the cyan accent); accent green brightened. Light-mode values unchanged. - SegmentList file rows: taller, bordered, more rounded; red hover on the remove ×. - New FOV pill overlaid top-center on the preview (`FOV 75° · Constrained`), non-interactive so pan/zoom drag underneath still works. - Fixed the toolbar's floating panel-toggle: it was a bare Rectangle with no `x` sibling to the toolbar's HorizontalBox, which Slint centers inside the parent instead of placing it at the far right. Moved into the toolbar row's own flow as a proper icon button (⇤/⇥). Pure visual/styling change - no new functionality, no property or callback signature changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
All contributors have signed the CLA. Thank you! |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One consistent flat visual language across the toolbar and panels,
replacing std-widgets
Buttonand the earlier ad-hocSectionHeader.FlatButtoncomponent (28px, 7px radius, flat fill + hoverlighten, blue
primaryvariant) replaces all std-widgetsButtonusages across the toolbar, panels, and dialogs.
TransportButtoncomponent for the tight playback-controlscluster (jump/step/play icons); the play/pause button gets an
emphasized(accent-tinted, wider) variant.SectionHeaderrebuilt: a filled yellow square when expanded(visible at a glance across a stack of collapsed sections) plus a
›/⌄ chevron, instead of a plain ▸/▾ text glyph.
toward the cyan accent); accent green brightened. Light-mode values
are unchanged.
SegmentListfile rows: taller, bordered, more rounded; red hoveron the remove ×.
FOV 75° · Constrained), non-interactive so pan/zoom drag underneath stillworks.
Rectanglewith no
x, sibling to the toolbar'sHorizontalBox- Slintcenters an unpositioned element inside its parent, so the ◀/▶ glyph
floated in the middle of the toolbar instead of sitting at the far
right. Moved into the toolbar row's own flow as a proper icon button
(⇤/⇥).
Pure visual/styling change - no new functionality, no property or
callback signature changes, no Rust changes.
This is a deliberately scoped-down extraction: the original fork
implementation bundled this restyle together with 7 unrelated
functional features (sync-offset auto-detection, variable playback
speed, ground/top-plane tilt sliders, etc.) in one commit. Splitting it
out cleanly meant re-deriving the visual-only pieces against current
main, rather than cherry-picking.Test plan
cargo check -p reco-gui --all-targetscleancargo test -p reco-gui— 6/6 passing (no test coverage change,this PR touches only
.slint)cargo clippy -p reco-gui --all-targets -- -D warnings— no newfindings; failures shown are the same pre-existing
reco-coredead-code/unsafe-ptr issues already tracked by Clear pre-existing clippy -D warnings failures on Windows #423
Button→FlatButtoncallsite for property compatibility (
text/enabled/clickedonly- no usages relied on
Button-only features likecheckable)