[CI] [History Server] Enhance CI ecosystem - #5247
Open
CheyuWu wants to merge 2 commits into
Open
Conversation
CheyuWu
marked this pull request as draft
September 5, 2026 13:21
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
CheyuWu
force-pushed
the
ci/historyserver-golangci-lint
branch
from
September 5, 2026 13:57
a0afd7d to
82e13bc
Compare
6 tasks
Collaborator
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 82e13bc. Configure here.
CheyuWu
commented
Sep 5, 2026
| }, TestTimeoutMedium).Should(Succeed()) | ||
| } | ||
|
|
||
| func listAzureBlobDirectories(containerClient *container.Client, prefix string) ([]string, error) { |
Collaborator
Author
There was a problem hiding this comment.
This function is unused, so I remove it
CheyuWu
commented
Sep 5, 2026
| golangci-lint: ## Download golangci-lint locally if necessary. | ||
| test -s $(GOLANGCI_LINT) || (curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | bash -s -- -b $(REPO_ROOT_BIN)/ $(GOLANGCI_LINT_VERSION)) | ||
|
|
||
| .PHONY: issuelint |
Collaborator
Author
There was a problem hiding this comment.
This code needed improvement, so I refined it.
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
CheyuWu
force-pushed
the
ci/historyserver-golangci-lint
branch
from
September 5, 2026 15:28
82e13bc to
25ae8de
Compare
CheyuWu
marked this pull request as ready for review
September 5, 2026 15:28
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
CheyuWu
commented
Sep 5, 2026
Comment on lines
+142
to
+149
| { | ||
| name: "/api/cluster_status endpoint (live cluster)", | ||
| testFunc: testLiveClusterStatus, | ||
| }, | ||
| { | ||
| name: "/api/cluster_status endpoint (dead cluster)", | ||
| testFunc: testDeadClusterStatus, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
I add this back because testLiveClusterStatus and testDeadClusterStatus is unused.
Collaborator
Author
|
cc @win5923 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
historyserver/was the only Go module not covered by the repo-wide golangci-lint setup. Itsmake alllinttarget pointed at.golangci.yaml/.golangci.info.yamlconfig files that don't exist in the module, so it never actually ran.This PR wires
historyserver/into the shared lint pipeline and fixes all resulting findings:historyservertoscripts/lint.sh, so it is linted by the existinggolangci-lintpre-commit hook (and theLint (pre-commit)CI job) with the repo-root.golangci.yml.alllint/issuelint/todolist/install-golinttargets with a standardmake linttarget that installs golangci-lintv2.11.4(matching.pre-commit-config.yaml) intobin/.%v->%won wrapped errors,err == X->errors.Is,interface{}->any, import grouping,noctx(newtest/support.HTTPGethelper for context-bound requests in e2e tests), testify assertion style, and//nolint:gosecwith explanations where the finding is a false positive..golangci.yml:errcheckonResponseWriter.Write/ go-restfulResponse.Write*,misspelloncancelled(Ray's own spelling in itsErrorTypeenum and raylet debug state),gosecG117 onSessionKey(a Ray session id, not a credential), andstaticcheckSA1019 foraws-sdk-gov1, which the S3 backend still uses.No behavior changes.
Related issue number
Closes #4813
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions