[CI] [History Server] Build collector and history server images in CI - #5248
Open
CheyuWu wants to merge 1 commit into
Open
[CI] [History Server] Build collector and history server images in CI#5248CheyuWu wants to merge 1 commit into
CheyuWu wants to merge 1 commit into
Conversation
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
Collaborator
Author
|
@win5923 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need to add a build docker image CI pipeline for historyserver
Related issue number
Part of #4813 (task 1 - build and verify Dockerfiles in CI). Task 2 (
golangci-lintforhistoryserver) is handled in #5247.Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions
Ran the exact command the new CI step runs, and both images build successfully:
cd historyserver make localimage-build