Skip to content

[Bug][Cleanup] Remove no-op WorkersToDelete resets in RayCluster controller #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markwu7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug][Cleanup] Remove no-op WorkersToDelete resets in RayCluster controller #5217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ray-operator/controllers/ray/raycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,6 @@ func (r *RayClusterReconciler) reconcilePods(ctx context.Context, instance *rayv
r.Recorder.Eventf(instance, nil, corev1.EventTypeNormal, string(utils.DeletedWorkerPod), string(utils.DeleteAction), "Deleted pod %s/%s", pod.Namespace, pod.Name)
}
}
worker.ScaleStrategy.WorkersToDelete = []string{}

runningPods := corev1.PodList{}
for _, pod := range workerPods.Items {
Expand Down Expand Up @@ -1355,11 +1354,8 @@ func (r *RayClusterReconciler) reconcileMultiHostWorkerGroup(ctx context.Context
if err := r.deletePods(ctx, instance, podsToDel, worker.GroupName, "autoscaler scale-down request"); err != nil {
return err
}
worker.ScaleStrategy.WorkersToDelete = []string{}
return fmt.Errorf("deleted %d worker Pods based on ScaleStrategy, requeueing", len(podsToDel))
}
// Clear WorkersToDelete after deletion.
worker.ScaleStrategy.WorkersToDelete = []string{}
}

// 5. Calculate Pod diff for scaling up or down by NumOfHosts.
Expand Down
Loading