[Bug][Cleanup] Remove no-op WorkersToDelete resets in RayCluster controller - #5217
Open
markwu7 wants to merge 1 commit into
Open
[Bug][Cleanup] Remove no-op WorkersToDelete resets in RayCluster controller#5217markwu7 wants to merge 1 commit into
markwu7 wants to merge 1 commit into
Conversation
Signed-off-by: Mark <markhww.jobs@gmail.com>
markwu7
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
August 30, 2026 16:54
win5923
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RayClusterReconcilerhad three statements that try to clearScaleStrategy.WorkersToDeletebut they’re ineffective, so these statements should not appear.Also, clearing
WorkersToDeleteis owned by the Ray Autoscaler, not the operator. Keeping these ineffective code is misleading.Related issue number
Closes #5206
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions