Skip to content

Make the gem rails 8.0 compatible #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adfoster-r7 merged 1 commit into from
Apr 14, 2026
Merged

Make the gem rails 8.0 compatible #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions metasploit-model.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'e2mmap'

# Dependency loading
# Rails 8.0 upgrade: widened from '~> 7.0' (which means >= 7.0, < 8.0) to
# '>= 7.0', '< 8.1' so this gem resolves with both Rails 7.x and 8.0.
# The old pessimistic constraint hard-blocked Bundler from pulling Rails 8.
spec.add_runtime_dependency 'activemodel', '>= 7.0', '< 8.1'
spec.add_runtime_dependency 'activesupport', '>= 7.0', '< 8.1'

spec.add_runtime_dependency 'activemodel', '~> 7.0'
spec.add_runtime_dependency 'activesupport', '~> 7.0'

spec.add_runtime_dependency 'railties', '~> 7.0'
spec.add_runtime_dependency 'railties', '>= 7.0', '< 8.1'

if RUBY_PLATFORM =~ /java/
# markdown formatting for yard
Expand Down
3 changes: 3 additions & 0 deletions spec/dummy/config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ class Application < Rails::Application
# Enable escaping HTML in JSON.
config.active_support.escape_html_entities_in_json = true

# Set cache format version for Rails 7.2+ compatibility

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says this is for “Rails 7.2+ compatibility”, but cache_format_version was introduced as part of the Rails 7.1 cache serialization change and 7.0 specifically opts into the older cache format. Please clarify the intent (eg, keeping the old cache format for upgrade/rolling-deploy compatibility) and adjust the wording/version accordingly so future readers don’t assume this is a Rails 7.2 requirement.

Suggested change
# Set cache format version for Rails 7.2+ compatibility
# Keep the Rails 7.0 cache format for upgrade/rolling-deploy compatibility.

Copilot uses AI. Check for mistakes.
config.active_support.cache_format_version = 7.0

end
end

Loading