Make the gem rails 8.0 compatible - #74
Conversation
fb0e93e to
36ea3b4
Compare
36ea3b4 to
51de252
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the gem’s Rails dependency constraints and the dummy Rails app configuration to allow the project to resolve and run under Rails 8.0 while retaining compatibility with Rails 7.x.
Changes:
- Widened runtime dependency constraints for
activemodel,activesupport, andrailtiesto support Rails 7.x through 8.0.x. - Added
config.active_support.cache_format_versionto the dummy app configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
spec/dummy/config/application.rb |
Sets an ActiveSupport cache format version in the dummy app to accommodate newer Rails behavior. |
metasploit-model.gemspec |
Broadens Rails component version constraints to allow Rails 8.0 resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Enable escaping HTML in JSON. | ||
| config.active_support.escape_html_entities_in_json = true | ||
|
|
||
| # Set cache format version for Rails 7.2+ compatibility |
There was a problem hiding this comment.
The comment says this is for “Rails 7.2+ compatibility”, but cache_format_version was introduced as part of the Rails 7.1 cache serialization change and 7.0 specifically opts into the older cache format. Please clarify the intent (eg, keeping the old cache format for upgrade/rolling-deploy compatibility) and adjust the wording/version accordingly so future readers don’t assume this is a Rails 7.2 requirement.
| # Set cache format version for Rails 7.2+ compatibility | |
| # Keep the Rails 7.0 cache format for upgrade/rolling-deploy compatibility. |
Make the gem rails 8.0 compatible