Remove SocketOptionName.KeepAlive setting

RabbitMQ.Stream.Client/Client.cs

@@ -74,7 +74,7 @@ public string ClientProvidedName
         public SslOption Ssl { get; set; } = new SslOption();
 
         /// <summary>
-        /// TCP socket options (buffer sizes, NoDelay, KeepAlive, Linger). When null, library defaults are used.
+        /// TCP socket options (buffer sizes, NoDelay, Linger). When null, library defaults are used.
         /// </summary>
         public SocketOptions SocketOptions { get; set; }
 

RabbitMQ.Stream.Client/Connection.cs

@@ -90,14 +90,12 @@ private static void ApplySocketOptions(Socket socket, SocketOptions options)
                 socket.NoDelay = true;
                 socket.SendBufferSize *= SocketOptions.DefaultBufferSizeMultiplier;
                 socket.ReceiveBufferSize *= SocketOptions.DefaultBufferSizeMultiplier;
-                socket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.KeepAlive, true);
                 return;
             }
 
             socket.NoDelay = options.NoDelay;
             socket.SendBufferSize = options.SendBufferSize ?? socket.SendBufferSize * SocketOptions.DefaultBufferSizeMultiplier;
             socket.ReceiveBufferSize = options.ReceiveBufferSize ?? socket.ReceiveBufferSize * SocketOptions.DefaultBufferSizeMultiplier;
-            socket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.KeepAlive, options.KeepAlive);
             if (options.LingerOption != null)
             {
                 socket.LingerState = options.LingerOption;

RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt

@@ -366,9 +366,9 @@ RabbitMQ.Stream.Client.RoutingStrategyType
 RabbitMQ.Stream.Client.RoutingStrategyType.Hash = 0 -> RabbitMQ.Stream.Client.RoutingStrategyType
 RabbitMQ.Stream.Client.RoutingStrategyType.Key = 1 -> RabbitMQ.Stream.Client.RoutingStrategyType
 RabbitMQ.Stream.Client.SocketOptions
-RabbitMQ.Stream.Client.SocketOptions.SocketOptions() -> void
 RabbitMQ.Stream.Client.SocketOptions.KeepAlive.get -> bool
 RabbitMQ.Stream.Client.SocketOptions.KeepAlive.set -> void
+RabbitMQ.Stream.Client.SocketOptions.SocketOptions() -> void
 RabbitMQ.Stream.Client.SocketOptions.LingerOption.get -> System.Net.Sockets.LingerOption
 RabbitMQ.Stream.Client.SocketOptions.LingerOption.set -> void
 RabbitMQ.Stream.Client.SocketOptions.NoDelay.get -> bool

RabbitMQ.Stream.Client/SocketOptions.cs

@@ -2,13 +2,14 @@
 // 2.0, and the Mozilla Public License, version 2.0.
 // Copyright (c) 2017-2023 Broadcom. All Rights Reserved. The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
 
+using System;
 using System.Net.Sockets;
 
 namespace RabbitMQ.Stream.Client
 {
     /// <summary>
     /// Configurable TCP socket options for a connection. Use this to tune buffer sizes,
-    /// Nagle's algorithm, linger on close, and TCP keep-alive.
+    /// Nagle's algorithm, and linger on close.
     /// </summary>
     public class SocketOptions
     {
@@ -35,8 +36,16 @@ public class SocketOptions
         public bool NoDelay { get; set; } = true;
 
         /// <summary>
-        /// Enable TCP keep-alive to detect dead connections. Default is true.
+        /// Deprecated TCP keep-alive option.
         /// </summary>
+        /// <remarks>
+        /// This property is intentionally ignored by the connection implementation and does not
+        /// enable TCP keep-alive on the underlying socket. The client library automatically
+        /// reconnects in case of connection failures, so explicit TCP keep-alive is not required.
+        /// The property is retained only for backward compatibility and to avoid a breaking
+        /// change in the public API; new code should not rely on it.
+        /// </remarks>
+        [Obsolete("KeepAlive is not needed since the library will automatically reconnect in case of connection failure.")]
         public bool KeepAlive { get; set; } = true;
 
         /// <summary>

RabbitMQ.Stream.Client/StreamSystem.cs

@@ -94,7 +94,7 @@ internal void Validate()
 
         /// <summary>
         /// See <see cref="SocketOptions"/> for configurable TCP socket options for a connection. Use this to tune buffer sizes,
-        /// Nagle's algorithm, linger on close, and TCP keep-alive.
+        /// Nagle's algorithm, and linger on close.
         /// </summary>
         public SocketOptions SocketOptions { get; set; } = null;
 

Tests/ClientTests.cs

@@ -482,16 +482,15 @@ public async Task ConnectWithDifferentSocketOptions()
             {
                 SocketOptions = new SocketOptions
                 {
-                    KeepAlive = true,
                     NoDelay = true,
                     ReceiveBufferSize = 1024 * 64,
                     SendBufferSize = 1024 * 64,
                 }
             };
             var client = await Client.Create(clientParameters);
             Assert.NotNull(client);
-            await client.Close("done");
-
+            await client.Close("done");
+
             var clientParameters1 = new ClientParameters
             {
                 SocketOptions = new SocketOptions

Tests/SystemTests.cs

@@ -504,5 +504,19 @@ public TestLookupLocatorStrategy(int maxAttempts, TimeSpan delay)
             public int MaxAttempts { get; init; }
             public TimeSpan Delay { get; }
         }
+
+        [Fact]
+        public async Task UseDnsEndpointShouldWork()
+        {
+            var config = new StreamSystemConfig()
+            {
+                Endpoints = new List<EndPoint> { new DnsEndPoint("localhost", 5552) }
+            };
+            var system = await StreamSystem.Create(config);
+            Assert.False(system.IsClosed);
+            await system.Close();
+            Assert.True(system.IsClosed);
+
+        }
     }
 }

docs/ReliableClient/BestPracticesClient.cs

@@ -1,4 +1,4 @@
-// This source code is dual-licensed under the Apache License, version
+// This source code is dual-licensed under the Apache License, version
 // 2.0, and the Mozilla Public License, version 2.0.
 // Copyright (c) 2017-2023 Broadcom. All Rights Reserved. The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
 
@@ -110,7 +110,7 @@ public static async Task Start(Config config)
                     // you can change them if you want to optimize the performance of the producer and consumer.
                     // SocketOptions = new SocketOptions()
                     // {
-                    //    // KeepAlive = true,
+                    //    // NoDelay = true,
                     //
                     // },
                     ConnectionPoolConfig = new ConnectionPoolConfig()

docs/asciidoc/api.adoc

@@ -206,7 +206,6 @@ Default is `null` with the default values:
  socket.NoDelay = true;
  socket.SendBufferSize *= SocketOptions.DefaultBufferSizeMultiplier;
  socket.ReceiveBufferSize *= SocketOptions.DefaultBufferSizeMultiplier;
- socket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.KeepAlive, true);
 ```
 
 [[connection-pool]]