Remove SocketOptionName.KeepAlive setting - #464
Merged
Conversation
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes explicit TCP keep-alive socket option application to address failures when connecting via DnsEndPoint on .NET 8/Linux (issue #463), while keeping the public SocketOptions.KeepAlive property for compatibility.
Changes:
- Stop setting
SocketOptionName.KeepAliveinConnection.ApplySocketOptions(both default and customSocketOptionspaths). - Mark
SocketOptions.KeepAliveas obsolete and remove KeepAlive references from docs/examples/tests. - Add a system test covering
DnsEndPointconnectivity.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/asciidoc/api.adoc | Removes KeepAlive from the documented default socket options snippet. |
| docs/ReliableClient/BestPracticesClient.cs | Updates example socket options comment to no longer reference KeepAlive. |
| Tests/SystemTests.cs | Adds a system test validating DnsEndPoint can be used in StreamSystemConfig.Endpoints. |
| Tests/ClientTests.cs | Removes usage of SocketOptions.KeepAlive in client socket options test. |
| RabbitMQ.Stream.Client/StreamSystem.cs | Updates StreamSystemConfig.SocketOptions XML docs to remove KeepAlive mention. |
| RabbitMQ.Stream.Client/SocketOptions.cs | Marks KeepAlive obsolete (kept for API compatibility). |
| RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt | Updates public API tracking file ordering for SocketOptions entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@bangjiehan will release a patch on Monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463
This PR removes explicit TCP keep-alive socket option application to address failures when connecting via
DnsEndPointon .NET 8/Linux (issue #463), while keeping the publicSocketOptions.KeepAliveproperty for compatibility.Changes:
SocketOptionName.KeepAliveinConnection.ApplySocketOptions(both default and customSocketOptionspaths).SocketOptions.KeepAliveas obsolete and remove KeepAlive references from docs/examples/tests.DnsEndPointconnectivity.