Skip to content

ci: make pre-release test job non-blocking#84

Closed
Marius1311 wants to merge 1 commit into
mainfrom
Marius1311/ci-prerelease-nonblocking
Closed

ci: make pre-release test job non-blocking#84
Marius1311 wants to merge 1 commit into
mainfrom
Marius1311/ci-prerelease-nonblocking

Conversation

@Marius1311

Copy link
Copy Markdown
Member

What

Mark the hatch-test.*-pre (PRE-RELEASE DEPENDENCIES) matrix legs continue-on-error, so a failing pre-release environment no longer fails the required Tests pass in all hatch environments gate.

Why

The py3.14-pre job runs with UV_PRERELEASE=allow and currently blocks merges whenever an upstream pre-release dependency is incompatible — e.g. PR #82 is blocked by a pandas pre-release change (Categorical backing arrays became read-only), which fails 3 tests in test_obs_beautifier.py::test_reorder_categories_with_nan_values. That failure:

  • is upstream-driven, not caused by any PR (it pre-exists on main — a scheduled run on the same SHA passed before the pandas pre-release and failed after), and
  • has no soft-fail escape hatch here, unlike the sister repo cellmapper (whose workflow already marks the pre job continue-on-error).

This change brings the workflow in line with cellmapper: the pre-release job stays a visible early-warning signal but stops gating merges. The alls-green gate then passes because a continue-on-error matrix leg doesn't count as a failure.

Effect

Unblocks PR #82 and any future PR while the upstream pandas pre-release incompatibility persists. (Optionally, the test could later be hardened against read-only Categorical backing so the pre signal goes green legitimately — out of scope here.)

🤖 Generated with Claude Code

The hatch-test py3.14-pre matrix entry runs with UV_PRERELEASE=allow and
currently fails the required "Tests pass in all hatch environments" gate
whenever an upstream pre-release dependency is incompatible (e.g. a pandas
pre-release making Categorical backing arrays read-only). These failures
are upstream-driven and pre-exist on main, so they should warn rather than
block merges.

Mark the pre-release matrix legs continue-on-error (mirrors the cellmapper
workflow) so the alls-green gate stays green while the pre job remains a
visible early-warning signal.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (a8872da) to head (3d5eeee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   80.83%   78.64%   -2.19%     
==========================================
  Files          15       15              
  Lines        1372     1372              
==========================================
- Hits         1109     1079      -30     
- Misses        263      293      +30     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Marius1311

Copy link
Copy Markdown
Member Author

Closing — this masked the symptom rather than fixing the cause, which isn't what we want here. Investigation shows the py3.14-pre failure was an upstream pandas pre-release regression (ValueError: assignment destination is read-only on a scalar .loc assignment into a categorical obs column). It is already fixed in pandas 3.0.3: a faithful repro (AnnData obs + the exact assignment) passes on pandas 3.0.3 + numpy 2.5.0rc1. No code/test change needed; re-running CI (which now resolves pandas 3.0.3) should make #82 green. Branch deleted.

@Marius1311 Marius1311 closed this Jun 9, 2026
@Marius1311 Marius1311 deleted the Marius1311/ci-prerelease-nonblocking branch June 9, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant