Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 990 996 +6
=========================================
+ Hits 990 996 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
damarkian
approved these changes
Jul 6, 2026
damarkian
approved these changes
Jul 24, 2026
chmwzc
marked this pull request as draft
July 30, 2026 03:08
scarrazza
approved these changes
Jul 31, 2026
for more information, see https://pre-commit.ci
# Conflicts: # src/qibochem/measurement/util.py
- Product of phases was wrong - Wrong column reference for CNOT gate phase update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapping of mutually generally commuting terms occasionally messes up the qubits to be measured if the given term group doesn't span the entire possible space, e.g.This PR solves this by adding a dict to get back and use the original set of qubits after mapping the Pauli terms.Edit: Using this PR to fix some other bugs that JF found as well
Edit 2: Reverting the addition of SWAP gates after circuit synthesis; it's simpler to just re-label instead. This PR is now just bug-fixing.