[WAVE 1] Test cost printing across uneven multiphase states#1076
Open
mickaelbegon wants to merge 2 commits into
Open
[WAVE 1] Test cost printing across uneven multiphase states#1076mickaelbegon wants to merge 2 commits into
mickaelbegon wants to merge 2 commits into
Conversation
Contributor
Author
|
Wave 1 preparation update: this PR remains intentionally isolated. Full CI is waiting behind the shared Matplotlib prerequisite #1081; it will be marked ready after that lands and checks are rerun. |
mickaelbegon
force-pushed
the
codex/fix-712-multiphase-print-cost
branch
from
July 23, 2026 13:43
cf5b33d to
31527d0
Compare
mickaelbegon
marked this pull request as ready for review
July 23, 2026 13:46
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 196 196
Lines 21506 21506
=======================================
Hits 16616 16616
Misses 4890 4890
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solution.print_cost()on a multiphase OCP whose phases have different state dimensionsSolutionDatabehavior against the regression reported in Error sol.print_cost() #712The faulty key-based concatenation described in #712 has already disappeared in the current implementation. This focused regression test documents and protects the corrected behavior.
Validation
pytest tests/shard5/test_global_torque_driven_ocp.py::test_phase_transition_uneven_variable_number_by_mapping -qThis change is