test(server): follow #7151's tool status onto non-Prime rows - #64
Merged
Conversation
`pylon` has been red since #62. Adopting #7151 carries the adapter's status onto every tool lifecycle row, not just Prime's, and this suite asserted the opposite for `tool.started` and `tool.completed`. The assertions described the behavior before that commit rather than guarding a Pylon invariant — the test's subject is that Prime-specific handling does not leak into non-Prime paths, which still holds — so they follow upstream. The alternative was re-gating status to Prime only, which contradicts #7151's own test expecting `status: "inProgress"` on a non-Prime `item.started`; the two cannot both hold, and staying in step wins where Pylon has no stated reason. Worth remembering: this was caught by CI, not by me. A targeted run covered ProviderRuntimeIngestion.test.ts and missed the .activity.test.ts sibling, and I merged #62 without checking that pylon went green afterwards.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylonhas been red since #62 merged. This fixes it.Adopting
#7151in that batch carries the adapter's status onto every tool lifecycle row, not just Prime's.ProviderRuntimeIngestion.activity.test.tsasserted the opposite fortool.startedandtool.completed.Which side gives
Those assertions described the behavior before
#7151rather than guarding a Pylon invariant — the test's actual subject is that Prime-specific handling does not leak into non-Prime paths, and that still holds. So they follow upstream.The alternative was re-gating status to Prime only. I tried that first, and it fails
#7151's own test, which expectsstatus: "inProgress"on a non-Primeitem.started. The two cannot both hold, and staying in step with upstream wins where Pylon has no stated reason to diverge.Worth flagging: an earlier xhigh review raised exactly this as finding 9 — non-Prime
tool.completedcarrying raw status replaces the client's guaranteed"completed"default with an unvalidated passthrough, so an adapter forwarding a staleinProgresswould render a permanently-spinning tool. I recorded it as an upstream design decision. That risk is real but latent: the same review confirmed every current adapter reports a terminal status on completion. It stays in the ledger.How this got in
Two process failures, both mine:
ProviderRuntimeIngestion.test.tsand missed the.activity.test.tssibling.pylonwent green afterwards.Verification
accountDrainEndToEnd.test.tsthat is unrelated and not caused here — it fails identically on unmodifiedorigin/pylon, and passes in CI in 59ms while timing out locally at 60s. That is a local environment difference, not a regression.Model: Claude Opus 5 in Pylon.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.