Skip to content

Commit cd2bf98

Browse files
authored
test(server): follow #7151's tool status onto non-Prime rows (#64)
`pylon` has been red since #62. Adopting #7151 carries the adapter's status onto every tool lifecycle row, not just Prime's, and this suite asserted the opposite for `tool.started` and `tool.completed`. The assertions described the behavior before that commit rather than guarding a Pylon invariant — the test's subject is that Prime-specific handling does not leak into non-Prime paths, which still holds — so they follow upstream. The alternative was re-gating status to Prime only, which contradicts #7151's own test expecting `status: "inProgress"` on a non-Prime `item.started`; the two cannot both hold, and staying in step wins where Pylon has no stated reason. Worth remembering: this was caught by CI, not by me. A targeted run covered ProviderRuntimeIngestion.test.ts and missed the .activity.test.ts sibling, and I merged #62 without checking that pylon went green afterwards.
1 parent f079e4f commit cd2bf98

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.activity.test.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -555,8 +555,13 @@ describe("runtimeEventToActivities Prime tool lifecycle", () => {
555555
"codex-tool-update",
556556
"codex-tool-complete",
557557
]);
558-
expect(started?.payload).toMatchObject({ detail: "echo existing behavior" });
559-
expect(started?.payload).not.toHaveProperty("status");
558+
// `#7151` carries the adapter's status onto every tool lifecycle row, not
559+
// just Prime's. These assertions previously described the behavior before
560+
// that commit rather than guarding a Pylon invariant, so they follow it.
561+
expect(started?.payload).toMatchObject({
562+
detail: "echo existing behavior",
563+
status: "inProgress",
564+
});
560565
expect(updated?.payload).toMatchObject({
561566
status: "inProgress",
562567
detail: "existing progress",
@@ -568,8 +573,8 @@ describe("runtimeEventToActivities Prime tool lifecycle", () => {
568573
expect(completed?.payload).toMatchObject({
569574
detail: "existing result",
570575
data: { exitCode: 0 },
576+
status: "completed",
571577
});
572-
expect(completed?.payload).not.toHaveProperty("status");
573578

574579
const fallbackSummaries = [
575580
runtimeEventToActivities({

0 commit comments

Comments
 (0)