fix(deps): repin expo patches to the versions a fresh resolve picks - #243
Merged
Conversation
Release Smoke regenerates the lockfile from scratch, so it resolves expo-sharing and expo-modules-jsi to the newest versions their ranges allow. The registry published 57.0.17 and 57.0.7, which left the patches pinned at 57.0.16 and 57.0.6 unused and failed the job on every branch, including pylon. Both patches apply unchanged to the new versions, so the pins, the patch filenames, and the lockfile all move up together.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Smoke is currently failing on
pylonitself and on every open PR,including ones that touch no mobile code.
Problem
scripts/release-smoke.tsdeletespnpm-lock.yamland re-resolves from themanifests, so it always picks the newest version each range allows. The registry
published
expo-sharing@57.0.17andexpo-modules-jsi@57.0.7, which our rangesaccept — so the fresh resolve no longer contains the
57.0.16and57.0.6versions our patches are pinned to:
The committed lockfile still held the older resolutions, so ordinary
vp ikeptworking and only the release job noticed.
Fix
Both patches apply to the new versions with no changes — verified by unpacking
the published tarballs and running
git apply --check. So the pins, the patchfilenames, and the lockfile all move up together, keeping the two views of the
dependency graph consistent.
Verification
node scripts/release-smoke.tslocally: wasexit 1onpylon, nowRelease smoke checks passed.The diff is 3 manifests, 2 patch renames, and thematching lockfile entries.
Not caused by any in-flight branch — reproduced on
pylonatd4444c34dbeforemaking any change.
Model: Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.