Skip to content

fix(deps): repin expo patches to the versions a fresh resolve picks - #243

Merged
rynfar merged 1 commit into
pylonfrom
fix/expo-patch-pins
Sep 2, 2026
Merged

fix(deps): repin expo patches to the versions a fresh resolve picks#243
rynfar merged 1 commit into
pylonfrom
fix/expo-patch-pins

Conversation

@rynfar

@rynfar rynfar commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Release Smoke is currently failing on pylon itself and on every open PR,
including ones that touch no mobile code.

Problem

scripts/release-smoke.ts deletes pnpm-lock.yaml and re-resolves from the
manifests, so it always picks the newest version each range allows. The registry
published expo-sharing@57.0.17 and expo-modules-jsi@57.0.7, which our ranges
accept — so the fresh resolve no longer contains the 57.0.16 and 57.0.6
versions our patches are pinned to:

[ERR_PNPM_UNUSED_PATCH] The following patches were not used: expo-modules-jsi@57.0.6, expo-sharing@57.0.16

The committed lockfile still held the older resolutions, so ordinary vp i kept
working and only the release job noticed.

Fix

Both patches apply to the new versions with no changes — verified by unpacking
the published tarballs and running git apply --check. So the pins, the patch
filenames, and the lockfile all move up together, keeping the two views of the
dependency graph consistent.

Verification

node scripts/release-smoke.ts locally: was exit 1 on pylon, now
Release smoke checks passed. The diff is 3 manifests, 2 patch renames, and the
matching lockfile entries.

Not caused by any in-flight branch — reproduced on pylon at d4444c34d before
making any change.

Model: Claude Opus 5 in Claude Code.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Release Smoke regenerates the lockfile from scratch, so it resolves
expo-sharing and expo-modules-jsi to the newest versions their ranges allow.
The registry published 57.0.17 and 57.0.7, which left the patches pinned at
57.0.16 and 57.0.6 unused and failed the job on every branch, including pylon.

Both patches apply unchanged to the new versions, so the pins, the patch
filenames, and the lockfile all move up together.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 2, 2026
@rynfar
rynfar merged commit a509639 into pylon Sep 2, 2026
17 checks passed
@rynfar
rynfar deleted the fix/expo-patch-pins branch September 2, 2026 17:54
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.8 KiB 13.6 KiB −183 B (−1.3%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 6.9 KiB −2 B (−0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.8 KiB 6.6 KiB −181 B (−2.6%) 7.8 KiB
Codex Live turn WebSocket decoded 58.7 KiB 57.2 KiB −1.5 KiB (−2.5%) 66.4 KiB
Codex Live turn messages 11 10 −1 (−9.1%) 21
Claude Total thread wire 13.8 KiB 13.6 KiB −186 B (−1.3%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 6.9 KiB −4 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 6.8 KiB 6.6 KiB −182 B (−2.6%) 7.8 KiB
Claude Live turn WebSocket decoded 59.5 KiB 58.1 KiB −1.5 KiB (−2.5%) 66.4 KiB
Claude Live turn messages 11 10 −1 (−9.1%) 21

Baseline: 03defac · PR result: 872f0c5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.5 KiB
  • Claude decoded thread snapshot: 110.2 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant