fix(release): remove unused Expo patches - #240
Closed
rynfar wants to merge 1 commit into
Closed
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
rynfar
force-pushed
the
fix/release-unused-expo-patches
branch
from
September 2, 2026 17:43
a0a16a2 to
10e4718
Compare
Collaborator
Author
|
Superseded by #243, which landed the same reviewed patch retargets plus exact manifest pins. Its full CI and release smoke are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release smoke test regenerates
pnpm-lock.yamlfrom the workspace manifests. A fresh SDK 57 resolution now selectsexpo-sharing@57.0.17from the mobile app's~57.0.16range. It also selectsexpo-modules-core@57.0.15, whose~57.0.7dependency selectsexpo-modules-jsi@57.0.7. No workspace manifest pins the old patched versions, so pnpm rejects the staleexpo-sharing@57.0.16andexpo-modules-jsi@57.0.6patch registrations as unused.Both replacement tarballs still lack Pylon's required fixes: the sharing package does not preserve Android share filenames/mixed text-and-file payloads, and the JSI package still marks its runtime scheduler constructors
SWIFT_RETURNS_RETAINEDunder Xcode 26.3.Fix
Retarget the two existing patches, without changing their semantics, to the versions selected by a clean lockfile resolution. Refresh only the related Expo lock entries. Unused-patch enforcement remains enabled, and every other patch is unchanged.
Evidence
22e8c2b616fa52cea9cebac6505e31a0740fdb4e:node scripts/release-smoke.tsreproducedERR_PNPM_UNUSED_PATCHfor both old Expo versions.vp install --lockfile-only --ignore-scripts— passed; Vite Plus reported that the lockfile passes supply-chain policies.node scripts/release-smoke.ts— passed (Release smoke checks passed.).vp run --filter @t3tools/mobile typecheck— passed.vp fmt --check pnpm-workspace.yaml pnpm-lock.yaml— passed.git diff --check HEAD^— passed.Model: GPT-5.6
Harness: Prime Agent
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.