fix: F-2026-18800 | [Dual Defense] Short SVM send_funds Defaults TxType=0 While Claiming Funds → Mapped to GAS - #327
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodeUniversalTxEventaccepted a truncated event, logged "defaulting to Funds", then setTxType = 0. Wire 0 is GAS, not FUNDS.GAS credits the sender UEA via swap; FUNDS deposits PRC20 to the recipient. Same amount, different party.
TxType0 also selects FAST confirmation, so a truncated FUNDS transfer lost finality too.signature_datanow required, truncation is an error.from_ceastays optional.TxTypeleft at 0. Now rejected.Tests: three real devnet events as fixtures, every truncation of them rejected, leniency tests inverted,
constructInboundpinned so FUNDS never becomes GAS. 8 mutations, all caught.Also here: event cleaner race.
TestEventCleanerStopalready failed under-raceonaudit-fixes. The goroutine now owns its ticker and stop channel,running/stopChare behind a mutex, andStopwaits so shutdown cannot close the chain DB under an in-flight cleanup. 5 mutations, all caught.