Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of the sample game: four placeholder scenes (
title,valley,keep,lighthouse) built from scripts.art/models.py(Blender) andart/textures.pymake the models and textures, andtools/scenes.pywrites the scenes andscenes.list.tools/build.shregenerates all of it.features.jsonlists each engine feature the finished game uses, with the phase that adds it.tests/featurecheck.pyexports every scene and the disc, and fails if a feature due by the current phase is missing from the output.tests/featurecheck_selftest.pyruns each check kind against the editor's third-person template, once where the feature is present and once where it is absent.CI builds the engine and
splashpack-cliat the pinned revisions incheck.yml, then runs both checks and confirms the committed scenes matchtools/scenes.py.@CloudMracek, one question: should this repo follow the splashedit-ng rule, where I merge without review, or keep peer review like the other repos? I'll wait for your review until you say.