Fix: remove incompatible nodejs/npm/cspell install from Dockerfile (cherry-pick #340) - #341
Merged
rquidute merged 1 commit intoJul 14, 2026
Conversation
npm@latest now requires node >=22, incompatible with the node 20.x installed here, breaking the backend image build (npm error EBADENGINE). Spell checking already runs independently in CI via streetsidesoftware/cspell-action (.github/workflows/spell-check.yml) and scripts/lint.sh is only invoked by developers locally — neither needs node/npm/cspell baked into the runtime image. Fixes #1044
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
antonio-amjr
approved these changes
Jul 14, 2026
rquidute
deleted the
fix/1044-remove-node-npm-cspell-from-dockerfile-v2.16
branch
July 14, 2026 21:00
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks the Dockerfile fix from #340 (
v2.15.1-develop) ontov2.16-develop.npm install -g npm@latestnow resolves to an npm release requiring Node >=22.22.2, incompatible with the Node 20.x installed in theDockerfile, breaking the backend image build withnpm error EBADENGINE(#1044).Spell checking already runs independently in CI via
streetsidesoftware/cspell-action(.github/workflows/spell-check.yml), andscripts/lint.sh— the only in-repo consumer of thecspellCLI — is only ever invoked by developers locally, never at container build or runtime. So node/npm/cspell don't need to be baked into the runtime image at all.Note:
v2.16-developalready has the separateCommissionDeviceTestimport fix (#335), so only the Dockerfile change from #340 is cherry-picked here — the rest of #340 (flake8 cleanup, import fix) is either already present or not applicable to this branch.Type of change
Related issue
Fixes #1044
Testing
Cherry-picked cleanly, no conflicts. Docker not available in this dev environment — requesting a fresh install/build run to confirm.