Skip to content

Commit 70284e9

Browse files
authored
Remove nodejs/npm/cspell install from Dockerfile (#341)
npm@latest now requires node >=22, incompatible with the node 20.x installed here, breaking the backend image build (npm error EBADENGINE). Spell checking already runs independently in CI via streetsidesoftware/cspell-action (.github/workflows/spell-check.yml) and scripts/lint.sh is only invoked by developers locally — neither needs node/npm/cspell baked into the runtime image. Fixes #1044
1 parent c810764 commit 70284e9

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

Dockerfile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ RUN curl -sSL https://install.python-poetry.org | python3 - && \
6161
# Install Docker
6262
RUN curl -sSL https://get.docker.com/ | sh
6363

64-
# Install nodejs, npm and spell checker
65-
RUN curl -sL https://deb.nodesource.com/setup_20.x | bash -
66-
RUN apt-get install -y nodejs
67-
RUN npm install -g npm@latest
68-
RUN npm install -g cspell@latest
69-
7064
# Allow installing dev dependencies to run tests
7165
# Copy poetry dependecy files and install dependencies
7266
# We copy install dependencies before copying all app source to reuse the dependency install step in docker.

0 commit comments

Comments
 (0)