Fix: remove incompatible nodejs/npm/cspell install from Dockerfile - #340
Merged
rquidute merged 3 commits intoJul 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version information, removes the installation of Node.js, npm, and the cspell spell checker from the Dockerfile, and updates the Matter SDK Docker tag and SHA in the configuration. There are no review comments, so we have no feedback to provide.
|
Tick the box to add this pull request to the merge queue (same as
|
npm@latest now requires node >=22, incompatible with the node 20.x installed here, breaking the backend image build (npm error EBADENGINE). Spell checking already runs independently in CI via streetsidesoftware/cspell-action (.github/workflows/spell-check.yml) and scripts/lint.sh is only invoked by developers locally — neither needs node/npm/cspell baked into the runtime image. Fixes #1044
rquidute
force-pushed
the
fix/1044-remove-node-npm-cspell-from-dockerfile
branch
from
July 14, 2026 13:15
78511af to
d6f7941
Compare
antonio-amjr
approved these changes
Jul 14, 2026
At SDK_SHA df8bd0308caa0680e2a78cda724a959e5b385205 (v1.6.1-mve-branch), CommissionDeviceTest lives in matter.testing.CommissioningPreTest again, not matter.testing.commissioning (where it had been moved to prior to backend #316, for an older SDK pin). The SDK has since moved it back, breaking --get-test-info and all Python test commissioning with: ImportError: cannot import name 'CommissionDeviceTest' from 'matter.testing.commissioning'
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
nodejs/npm/cspellinstall step from the backendDockerfile.npm install -g npm@latestnow resolves to an npm release that requires Node >=22.22.2, incompatible with the Node 20.x installed a few lines above — this broke the backend image build withnpm error EBADENGINE(see #1044).Spell checking already runs independently in CI via
streetsidesoftware/cspell-action(.github/workflows/spell-check.yml), andscripts/lint.sh— the only in-repo consumer of thecspellCLI — is only ever invoked by developers locally, never at container build or runtime. So node/npm/cspell don't need to be baked into the runtime image at all.Type of change
Related issue
Fixes #1044
Testing
Removed the four
RUNlines; no other script in the repo (build, prestart, CI) referencesnodejs/npm/cspellinside the container. Requesting a fresh image build/install run to confirm the fix (Docker not available in this dev environment).