forked from enketo/enketo-core
-
Notifications
You must be signed in to change notification settings - Fork 0
Tile caching #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wilblack
wants to merge
4
commits into
master
Choose a base branch
from
tile-caching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tile caching #1
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9d51682
Got the offline layer to load.
wilblack 4c21e4e
Got a single map source to cahce and load. Need to add suport for mul…
wilblack 88d7293
Got two layers working. Added stroeName to config.maps.
wilblack 6e4e023
Added a flag alled cachingTiles, so the alert doesn't pop-up multiple…
wilblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| { | ||
| "name": "enketo-core", | ||
| "version": "3.0.3", | ||
| "homepage": "https://github.com/enketo/enketo-core", | ||
| "authors": [ | ||
| "Martijn van de Rijdt <martijn@enketo.org>" | ||
| ], | ||
| "license": "Apache2", | ||
| "private": true, | ||
| "ignore": [ | ||
| "**/.*", | ||
| "node_modules", | ||
| "bower_components", | ||
| "test", | ||
| "tests" | ||
| ], | ||
| "dependencies": { | ||
| "q": "1.0.1", | ||
| "jquery": "~2.1.1", | ||
| "requirejs": "~2.1.15" | ||
| } | ||
| "name": "enketo-core", | ||
| "version": "3.0.3", | ||
| "homepage": "https://github.com/enketo/enketo-core", | ||
| "authors": [ | ||
| "Martijn van de Rijdt <martijn@enketo.org>" | ||
| ], | ||
| "license": "Apache2", | ||
| "private": true, | ||
| "ignore": [ | ||
| "**/.*", | ||
| "node_modules", | ||
| "bower_components", | ||
| "test", | ||
| "tests" | ||
| ], | ||
| "dependencies": { | ||
| "q": "1.0.1", | ||
| "jquery": "~2.1.1", | ||
| "requirejs": "~2.1.15" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,11 +18,25 @@ | |
| "maps": [ { | ||
| "tiles": [ "http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png" ], | ||
| "name": "streets", | ||
| "attribution": "Map data © <a href=\"http://openstreetmap.org\">OpenStreetMap</a> contributors" | ||
| }, { | ||
| "tiles": [ "http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png" ], | ||
| "name": "layer2", | ||
| "attribution": "Map data © <a href=\"http://openstreetmap.org\">OpenStreetMap</a> contributors" | ||
| "attribution": "Map data © <a href=\"http://openstreetmap.org\">OpenStreetMap</a> contributors", | ||
| "storeName": "osmTiles" | ||
| }, | ||
| { | ||
| "tiles": [ "http://tile.stamen.com/watercolor/{z}/{x}/{y}.jpg" ], | ||
| "name": "watercolor", | ||
| "attribution": "Map tiles by <a href='http://stamen.com/''>Stamen Design</a> under <a href='http://creativecommons.org/licenses/by/3.0'>CC BY 3.0</a> Data by ", | ||
| "storeName": "watercolorTiles" | ||
|
|
||
| } ], | ||
| "regions" : [ | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are were we actually define the regions. It needs to be moved somewhere that a survey author can edit them. |
||
| { | ||
| "name": "Region 1 - Coos Bay to OR/CA Border", | ||
| "nLat": 43.5, | ||
| "sLat": 42.0, | ||
| "wLng": -124.7, | ||
| "eLng": -124.2 | ||
| } | ||
| ], | ||
|
|
||
| "google_api_key": "" | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the storeName keyword to maps to use as the name of the database to sore the tiles in. A better solution might be to slugify the map.nam field. But as long as only a developer is changing this value it might be fine.