Tile caching - #1
Open
wilblack wants to merge 4 commits into
Open
Conversation
…tiple map layers still.
… times when there is more than one map on the page or survey.
Author
There was a problem hiding this comment.
I added the storeName keyword to maps to use as the name of the database to sore the tiles in. A better solution might be to slugify the map.nam field. But as long as only a developer is changing this value it might be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@edrex
This is the first stab at integrating an offlineLayer with enketo. Hidden maps are not displaying properly, I suspect this is on enketo bug, not because of tile caching.
The regions are defined in config.json, this needs to move to somewhere that the survey author can define them. Also the config.json map objects need to include a 'storeName' to use are the name of the local database.
I stored the state of wether or not the tiles are already cached in localStorage. A better solution mught be to store that in the data store being used by the caching.