Fix FileWidget i18n msgid breakage introduced in #7982

[Wagner3UB]

Summary

PR #7982 (FileWidget - a11y) inadvertently changed the id fields of several defineMessages entries in FileWidget.jsx and RegistryImageWidget.jsx. Since the id is the key used at runtime to look up translations in .po files, renaming them effectively broke all existing translations for those strings — any site that had already translated the old keys would silently fall back to the English default.

This PR does two things:

1. Restores the original msgid id keys, so existing .po translations keep matching (backward compatibility).
2. Updates the defaultMessage values to improve accessibility: the new strings describe both interaction methods ("Press Enter or click") instead of keyboard only, and a new dragAndDropReplaceA11y message distinguishes the "replace existing file" state from the initial "upload" state announced to assistive technology.

Message key	Restored id (backward-compat)	Updated defaultMessage (a11y)
editFile	Drop file here to replace the existing file	File upload area. Press Enter or click to replace the existing file.
fileDrag	Drop file here to upload a new file	File upload area. Press Enter or click to open the file browser.
dragAndDropActionA11y	Press Enter to browse files from your computer.	File upload area. Press Enter or click to open the file browser.
dragAndDropReplaceA11y (new)	—	File upload area. Press Enter or click to replace the existing file.

The same defaultMessage updates are applied to RegistryImageWidget.jsx so both widgets share identical id and defaultMessage, avoiding an i18n extraction conflict on the shared keys.

[Wagner3UB]

@stevepiercy I need your attention here. The same problem I had with the PR https://github.com/plone/volto/pull/8320 happened here, but the PR has been merged. So, I'm trying to do a rollback for those IDs.

[stevepiercy]

Just a tweak on the news fragment. Otherwise LGTM.

Was there a release made since the inadvertant msgid change? If so, then there also needs to be a mention in the upgrade guide.

[Wagner3UB]

Was there a release made since the inadvertant msgid change? If so, then there also needs to be a mention in the upgrade guide.

@stevepiercy Yes, https://github.com/plone/volto/releases/tag/19.1.3. What do I need to mention?

[stevepiercy]

@Wagner3UB good question, and I'm not exactly sure. I'd say that a note for 19.1.3, as well as another for the next released version, would be appropriate.

I'm not sure of the surface area, that is, the group of developers who might be affected by the change. My guess is developers who relied on the those msgids in their add-ons previous to Volto 19.1.3 and are using Volto 19.1.3. Maybe some of the folks who understand the implications better than I can verify? @erral @davisagli @sneridagh @pnicolli

[wesleybl]

@Wagner3UB @stevepiercy If the text changes, shouldn't the id also change? Since ids are strings, I find it strange to have one text in the message and another in the id. It looks like an error. If I were using ids in my own project, I'd prefer the translations to "break." That would allow me to see the new message.

[stevepiercy]

@wesleybl think of it as a Python dict. A msgid is a key, msgstr is the value. msgid is the key used to look up the translated text msgstr in the language domain. If your code refers to a msgid that changes, it won't find a translation.

[wesleybl]

Review

Thanks for this fix! The core intent (restoring original msgid keys) is correct and important. A few issues to address:

1. DefaultMessage values are not unchanged (PR description is incorrect)

The PR description states "The defaultMessage values remain as introduced in #7982", but the diff shows FileWidget's defaultMessages are all being significantly changed to new accessibility-focused strings:

Message key	Old defaultMessage (#7982)	New defaultMessage (this PR)
editFile	Drop a file here or click to replace the existing file	File upload area. Press Enter or click to replace the existing file
fileDrag	Drop a file here or click to upload	File upload area. Press Enter or click to open the file browser
dragAndDropActionA11y	File upload area. Press Enter to open the file browser	File upload area. Press Enter or click to open the file browser

The new strings are better for accessibility. Please update the PR description to accurately reflect this.

2. Inconsistent editFile defaultMessage between FileWidget and RegistryImageWidget

Both widgets now share the same msgid "Drop file here to replace the existing file", but have different defaultMessages:

• FileWidget.jsx: 'File upload area. Press Enter or click to replace the existing file' (new a11y text)
• RegistryImageWidget.jsx: 'Drop file here to replace the existing file' (unchanged old text)

Is this intentional? If RegistryImageWidget should also show the new a11y-friendly text, its defaultMessage should be updated too.

3. visually-hidden → visually-hidden-volto change is good but should be mentioned

This is a correct fix (aligns with Volto's convention used in Toast.jsx and UrlWidget.jsx), but it's unrelated to the i18n msgid restoration. Please document it in the PR description.

Minor: duplicate type="file" on the input

Pre-existing issue, but line 218 explicitly sets type: 'file' which is already handled by getInputProps() on line 217-219. Not introduced by this PR though.

---

After addressing #1 (description update), this looks good to approve.

[Wagner3UB]

@wesleybl Done

@stevepiercy can you run your check here, please?

[stevepiercy]

This is changed from #7982. It was added in #7982. Was it included in a release? If so, then don't change the msgid. It's OK to change the Default.

[Wagner3UB]

@stevepiercy This msgid wasn't added in #7982, it existed before and had translations as well. #7982 renamed Press Enter to browse files from your computer. into it, which broke those. This PR just restores the original msgid and only changes the Default, as you suggested.

My bad for the mess with the IDs. It caused a huge chain reaction.

[stevepiercy]

I just double-checked. I stand by what I say. @Wagner3UB would you please double check?

https://github.com/plone/volto/pull/7982/changes#diff-d5d3803452ddc03817f874c414b3e6871c5f91c2c6d863fdfa9c6734277c5096R1624

[stevepiercy]

I just double-checked. I stand by what I say. @Wagner3UB would you please double check?

https://github.com/plone/volto/pull/7982/changes#diff-d5d3803452ddc03817f874c414b3e6871c5f91c2c6d863fdfa9c6734277c5096R1624

[wesleybl]

I still find it strange for the id to be something other than 'default', but okay.

[read-the-docs-community]

Documentation build overview

📚 volto | 🛠️ Build #33580059 | 📁 Comparing 2e59e4a against latest (a888abc)

  🔍 Preview build  

1 file changed

± upgrade-guide/index.html

[stevepiercy]

Thanks for the upgrade guide entry. That's nice.

[stevepiercy]

Thank you!