feature: add delete & rename dir for shared dirs - #57
Open
edurbrito-cyber wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
deleteandrenamefeatures to shared directories that fall under similar circumstances as:Now Y can delete/rename the subfolder.
However, there are still some related behaviors of shared folders for which the current permissions' logic fails, both in the frontend and backend.
The
movefunctionality also suffers from this strange permissions' logic and because of that I decided not to include it.There may be the need for a more thorough discussion to determine what else to implement and the desired behavior of this type of functionalities that target shared objects.